-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rustfmt.toml file to prevent flags.rs fmt on save #427
Conversation
Might be easier to just stick |
Not sure why all the parameters, where do these come from? |
generated from EDIT: Yeah after looking at the options, probably not worth just changing a couple of them. I just ran the command because I thought there was a reason we weren't using the I thought we had a rustfmt.toml file before anyway? Idk, could be useful at some point. but definitely got rid of all the options. |
0bbbd71
to
3039fb8
Compare
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Seems like clippy doesn't like it. I'll see if I can find an alternative
See: rust-lang/rust#64266 |
Huh, that's surprising. In that case I'd probably go for a |
See: rust-lang/rust#64266 Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Yea, seems Nix respect the rustfmt one, so that seems like the correct way to handle this. |
Was removing this was forgotten? Seems like it should be redundant with this change, no? Line 13 in 51790ed
|
Yeop 🤦♀️ |
Turns out, it doesn't read the rustfmt.toml. What I thought was it reading it was actually it reading it through taplo... Welp, guess we'll need to do it two places for now. |
This prevents most LSP's/Editors that will auto run rustfmt on save. Most do not respect the .nix file, so this will keep
flags.rs
from getting formatted each time someone contributes.